[webkit-reviews] review denied: [Bug 23860] Resync some graphics/skia files with their chromium counterparts : [Attachment 27669] fix curly brace

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 18 12:05:56 PST 2009


Eric Seidel <eric at webkit.org> has denied Evan Stade <estade at chromium.org>'s
request for review:
Bug 23860: Resync some graphics/skia files with their chromium counterparts
https://bugs.webkit.org/show_bug.cgi?id=23860

Attachment 27669: fix curly brace
https://bugs.webkit.org/attachment.cgi?id=27669&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I would name currentPath() to currentPathInLocalCoordinates() then you don't
need the comment and all the callsites are clear.

I would add a comment next to m_path explaining how it's stored transformed to
global coordinates *at time of setting* and that currentPathInLocalCoordinates
applies the inverse globalTransform at time of getting so that
getCTM().transform(currerntPathInLocalCoordinates()) works.

WebKit uses localPath instead of local_path and inverseMatrix instead of
inverse_matrix.

r- for the style issues.


More information about the webkit-reviews mailing list