[webkit-reviews] review granted: [Bug 23974] Deque::Remove would be a useful method. : [Attachment 27709] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 18 11:06:48 PST 2009


Alexey Proskuryakov <ap at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 23974: Deque::Remove would be a useful method.
https://bugs.webkit.org/show_bug.cgi?id=23974

Attachment 27709: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=27709&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +	   Add Deque::remove and Deque*Iterator::copy.

As discussed on IRC, it's quite unclear why DequeIteratorBase<T>::operator= was
added, an explanation in ChangeLog would help a lot. Concrete iterators
assignment operators were calling Base::assign(), which in turn called this
unimplemented operator=. We could only get away with that because all this code
was unused.

Other containers' remove() methods have an early return for end(), so
Deque::remove should have it, too.

r=me, with this bug fixed, and a better ChangeLog.


More information about the webkit-reviews mailing list