[webkit-reviews] review requested: [Bug 23900] Prevent frames from calling themselves _top : [Attachment 27749] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 18 07:35:58 PST 2009


Sverrir Á. Berg <sverrir at chromium.org> has asked  for review:
Bug 23900: Prevent frames from calling themselves _top
https://bugs.webkit.org/show_bug.cgi?id=23900

Attachment 27749: New patch
https://bugs.webkit.org/attachment.cgi?id=27749&action=review

------- Additional Comments from Sverrir Á. Berg <sverrir at chromium.org>
I've abstracted the check to a member function and widened the check to all
invalid frame names (all starting with _).  I've also added a test.
Note that the test works fine on webkit trunk on Mac but crashes Win Nightly.

Please take another look


More information about the webkit-reviews mailing list