[webkit-reviews] review granted: [Bug 23989] The cursor behavior in GTK is wrong : [Attachment 27743] cursor.patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 23989: The cursor behavior in GTK is wrong
https://bugs.webkit.org/show_bug.cgi?id=23989

Attachment 27743: cursor.patch
https://bugs.webkit.org/attachment.cgi?id=27743&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> +static GdkCursor* lastSetCursor = 0;

There's no need to explicitly initialise this to zero.

> @@ -85,11 +74,11 @@ void Widget::setCursor(const Cursor& cursor)
>      // gdk_window_set_cursor() in certain GDK backends seems to be an
>      // expensive operation, so avoid it if possible.
>  
> -    if (pcur == m_data->cursor)
> +    if (pcur == lastSetCursor)
>	   return;
>  
>      gdk_window_set_cursor(gdkDrawable(platformWidget()) ?
GDK_WINDOW(gdkDrawable(platformWidget())) :
GTK_WIDGET(root()->hostWindow()->platformWindow())->window, pcur);
> -    m_data->cursor = pcur;
> +    lastSetCursor = pcur;
>  }

Ugh, does this code really use pcur as a variable name? :-(

r=me