[webkit-reviews] review denied: [Bug 23900] Prevent frames from calling themselves _top : [Attachment 27568] Prevent frames from naming themselves _top

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Sverrir Á. Berg
<sverrir at chromium.org>'s request for review:
Bug 23900: Prevent frames from calling themselves _top
https://bugs.webkit.org/show_bug.cgi?id=23900

Attachment 27568: Prevent frames from naming themselves _top
https://bugs.webkit.org/attachment.cgi?id=27568&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+	 WARNING: NO TEST CASES ADDED OR CHANGED

The fix looks reasonable, but it definitely needs an automated test case, r-
because of that. Note that I couldn't easily make Safari crash with the code
provided in bug 23899.

+	Make sure a frame does not name itself "_top".	This prevents a crash.

Please fix ChangeLog to use spaces, not tabs.

A better place for this line is in the generated part of ChangeLog:

+	 * page/FrameTree.cpp:
+	 (WebCore::FrameTree::uniqueChildName):