[webkit-reviews] review denied: [Bug 23860] Resync some graphics/skia files with their chromium counterparts : [Attachment 27511] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 13 14:24:51 PST 2009
Eric Seidel <eric at webkit.org> has denied Evan Stade <estade at chromium.org>'s
request for review:
Bug 23860: Resync some graphics/skia files with their chromium counterparts
https://bugs.webkit.org/show_bug.cgi?id=23860
Attachment 27511: patch
https://bugs.webkit.org/attachment.cgi?id=27511&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine
+ // Current path in global coordinates.
isn't actually right, is it?
If you change the current matrix, we don't update the path. So won't
currentPath() do the wrong thing?
Also WebKit style has {
+SkPath PlatformContextSkia::currentPath() const {
on its own line.
r- for the concerns about currentPath() doing the wrong thing if you have
changed the current transform since setting the path.
More information about the webkit-reviews
mailing list