[webkit-reviews] review requested: [Bug 23939] Release build being built with debugging symbols : [Attachment 27634] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 12 17:29:37 PST 2009


Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 23939: Release build being built with debugging symbols
https://bugs.webkit.org/show_bug.cgi?id=23939

Attachment 27634: proposed fix
https://bugs.webkit.org/attachment.cgi?id=27634&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
While searching for a way to protect CXXFLAGS from modification I found
webkit.m4 where WEBKIT_INIT (which is called by our configure.ac) is defined.
There is already an AC_PROG_CXX call there, which protects CXXFLAGS against
changes, and which is expanded as part of WEBKIT_INIT, so adding a second call
without the protection is no good.

I tested automake1.10 here after removing the second call, and it did not
complain about it missing, so I am not sure an issue actually exists.


More information about the webkit-reviews mailing list