[webkit-reviews] review granted: [Bug 23934] Skia platform doesn't render text decoration shadows : [Attachment 27625] Fix for 23934
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 12 16:28:31 PST 2009
Eric Seidel <eric at webkit.org> has granted Scott Violet <sky at google.com>'s
request for review:
Bug 23934: Skia platform doesn't render text decoration shadows
https://bugs.webkit.org/show_bug.cgi?id=23934
Attachment 27625: Fix for 23934
https://bugs.webkit.org/attachment.cgi?id=27625&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
144 // Returns the stroke color. The returned color has it's alpha adjusted
145 // by the current alpha.
Whoever lands this could change that comment to say "current context alpha"
instead of just "current alpha" to be more specific that this is the
context-wide alpha which CG supports, thus GraphicsContext supports, and thus
we support.
I talked this out with brett at length. The patch looks fine.
More information about the webkit-reviews
mailing list