[webkit-reviews] review requested: [Bug 23607] REGRESSION: Clicking near an contentEditable div will focus the div, even though it shouldn't! : [Attachment 27626] Fix for clicking below the last root line box with multiple line boxes.

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has asked  for review:
Bug 23607: REGRESSION: Clicking near an contentEditable div will focus the div,
even though it shouldn't!
https://bugs.webkit.org/show_bug.cgi?id=23607

Attachment 27626: Fix for clicking below the last root line box with multiple
line boxes.
https://bugs.webkit.org/attachment.cgi?id=27626&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
 LayoutTests/ChangeLog				    |	35 ++++
 ...ick-in-margins-inside-editable-div-expected.txt |	23 +++
 .../click-in-margins-inside-editable-div.html	    |	14 ++
 ...n-padding-with-multiple-line-boxes-expected.txt |	11 ++
 .../click-in-padding-with-multiple-line-boxes.html |	14 ++
 .../click-outside-editable-div-expected.txt	    |	20 ++
 .../selection/click-outside-editable-div.html	    |	14 ++
 .../selection/contenteditable-click-outside.html   |	13 --
 .../editing/selection/resources/TEMPLATE.html	    |	14 ++
 .../click-in-margins-inside-editable-div.js	    |	93 ++++++++++
 .../click-in-padding-with-multiple-line-boxes.js   |	62 +++++++
 .../resources/click-outside-editable-div.js	    |	49 +++++
 .../resources/js-test-selection-shared.js	    |	44 +++++
 .../editing/selection/select-missing-image.html    |	 2 +-
 ...contenteditable-click-outside-expected.checksum |	 1 -
 .../contenteditable-click-outside-expected.txt     |	16 --
 .../selection/select-all-iframe-expected.txt	    |	 4 +-
 .../select-from-textfield-outwards-expected.txt    |	 2 +-
 .../selection/select-missing-image-expected.txt    |	 3 +-
 .../contenteditable-click-outside-expected.txt     |	12 --
 .../selection/select-all-iframe-expected.txt	    |	56 ------
 WebCore/ChangeLog				    |	29 +++
 WebCore/editing/VisiblePosition.cpp		    |	10 +-
 WebCore/rendering/RenderBlock.cpp		    |  184 ++++++++++----------
 24 files changed, 525 insertions(+), 200 deletions(-)