[webkit-reviews] review granted: [Bug 23928] Fix run-webkit-tests to skip some dirs when new features are turned off : [Attachment 27615] Patch, changelog

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 23928: Fix run-webkit-tests to skip some dirs when new features are turned
off
https://bugs.webkit.org/show_bug.cgi?id=23928

Attachment 27615: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=27615&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +if (!checkWebCoreAcceleratedCompositingSupport(0)) {
> +    $ignoredDirectories{'compositing'} = 1;
> +}

I guess this is the style already used by SVG/WML, but I think something like
this would be clearer:

if (!checkWebCoreAcceleratedCompositingSupport({required => 0})) {

r=me