[webkit-reviews] review granted: [Bug 23912] REGRESSION: Select elements don't scroll in response to the mouse wheel : [Attachment 27616] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 23912: REGRESSION: Select elements don't scroll in response to the mouse
wheel
https://bugs.webkit.org/show_bug.cgi?id=23912

Attachment 27616: Patch
https://bugs.webkit.org/attachment.cgi?id=27616&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 40918)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,16 @@
> +2009-02-12  David Hyatt  <hyatt at apple.com>
> +
> +	   Fix for https://bugs.webkit.org/show_bug.cgi?id=23912
> +
> +	   I have no idea why this broke.  As far as I can tell the old code
never should have worked in
> +	   the first place.  Add code to handleWheelEvent that will find an
enclosing renderer for a node
> +	   in order to attempt a wheel scroll.
> +
> +	   Reviewed by NOBODY (OOPS!).

"Reviewed by" should go at the top. r-me.