[webkit-reviews] review granted: [Bug 23915] Remove setPrefix work-around in Document::createElement(QualifiedName, bool) : [Attachment 27587] Proposed fix: propage the qualifiedName

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 23915: Remove setPrefix work-around in
Document::createElement(QualifiedName, bool)
https://bugs.webkit.org/show_bug.cgi?id=23915

Attachment 27587: Proposed fix: propage the qualifiedName
https://bugs.webkit.org/attachment.cgi?id=27587&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    UNUSED_PARAM(ec); // FIXME: To be removed.

UNUSED_PARAM should only be used as a last resort. Here you can just remove the
parameter name "ec" from the function arguments list in the function definition
instead.

> +		   debug("FAILED: localName does not matche &lt;img&gt;");

There's an extra "e" here.

Please remove that unused ExceptionCode argument as soon as possible!

r=me