[webkit-reviews] review granted: [Bug 23920] build script doesn't respect setting installation prefix : [Attachment 27602] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 12 07:38:33 PST 2009
Adam Roben (aroben) <aroben at apple.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 23920: build script doesn't respect setting installation prefix
https://bugs.webkit.org/show_bug.cgi?id=23920
Attachment 27602: proposed fix
https://bugs.webkit.org/attachment.cgi?id=27602&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> + push @buildArgs, "--prefix=" . $prefix if(defined($prefix));
We normally leave out the parentheses around the condition in these postfix
ifs:
push @buildArgs, "--prefix=" . $prefix if defined($prefix);
r=me
More information about the webkit-reviews
mailing list