[webkit-reviews] review granted: [Bug 23859] Change worker code to use different proxy class pointers. : [Attachment 27584] Proposed Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 23859: Change worker code to use different proxy class pointers.
https://bugs.webkit.org/show_bug.cgi?id=23859

Attachment 27584: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=27584&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+#include "Console.h"
+#include "ScriptExecutionContext.h"
+#include <wtf/PassRefPtr.h>

Most of these includes do not look necessary in WorkerObjectProxy.h.

+// FIXME: For now, we just cast object proxy pointer in order to access the
functionalities needed for loader.

A FIXME should say what's wrong with the current situation, not just describe
it. To anyone actively working on this code, it's pretty obvious what the
problem is, but it may not be so obvious to others.

A good ChangeLog should say more about the changes - in this case, explaining
that this is a step towards splitting proxies for multi-process design would
suffice.

r=me - this patch looks really good!