[webkit-reviews] review granted: [Bug 23688] ThreadableLoader needs a sync implementation for Workers. : [Attachment 27562] Part 1: Put ResourceError in ThreadableLoaderClient

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 23688: ThreadableLoader needs a sync implementation for Workers.
https://bugs.webkit.org/show_bug.cgi?id=23688

Attachment 27562: Part 1: Put ResourceError in ThreadableLoaderClient
https://bugs.webkit.org/attachment.cgi?id=27562&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+    // FIXME: If the a site requests a local resource, then this will return a
non-zero value but the sync path
+    // will return a 0 value.	Either this should return 0 or the other code
path should do a callback with
+    // a failure.
     thisPtr->m_mainThreadLoader = ThreadableLoader::create(context, thisPtr,
*request, callbacksSetting, contentSniff);
-    if (!thisPtr->m_mainThreadLoader)
-	 thisPtr->didFail();

Seems that we should assert that the result is non-null here.

r=me