[webkit-reviews] review granted: [Bug 23906] Add custom V8 bindings for HTMLPlugInElement : [Attachment 27578] Add custom V8 bindings for HTMLPlugInElement, v1.1.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 23906: Add custom V8 bindings for HTMLPlugInElement
https://bugs.webkit.org/show_bug.cgi?id=23906

Attachment 27578: Add custom V8 bindings for HTMLPlugInElement, v1.1.
https://bugs.webkit.org/attachment.cgi?id=27578&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.  But why do we sometimes return an empty value handle and sometimes
an empty object handle?  Do we care?  Why aren't we consistent?

Seems eventually we should replace all these empty returns with something like:


return emptyHandle();

which does the right hting, whatever that is.