[webkit-reviews] review requested: [Bug 16482] Hook up ICU's encoding detector and add a boolean param to Settings and WebPreferences : [Attachment 27576] updated patch

[bugzilla-daemon at webkit.org]

Jungshik Shin <jshin at chromium.org> has asked  for review:
Bug 16482: Hook up ICU's encoding detector and add a boolean param to Settings
and WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=16482

Attachment 27576: updated patch 
https://bugs.webkit.org/attachment.cgi?id=27576&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
I updated comments to shouldAutoDetect to make it clear when auto-detection is
triggered. Here's recap:

// We use the encoding detector in two cases:
//   1. Encoding detector is turned ON and no other encoding source is
//	available (that is, it's DefaultEncoding).
//   2. Encoding detector is turned ON and the encoding is set to
//	the encoding of the parent frame, which is also auto-detected.
//   Note that condition #2 is NOT satisfied unless parent-child frame
//   relationship is compliant to the same-origin policy. If they're from
//   different domains, |m_source| would not be set to EncodingFromParentFrame
//   in the first place. 

I believe the above and *not* auto-detecting UTF-7 (and ISO-2022-XX) make this
rather safe. 

In addition to the above change, I tried to take care of style nits as far as I
could find.