[webkit-reviews] review granted: [Bug 23496] execCommand('bold') will remove <b style='font-style:italic'>, it should probably replace it with <span style='font-style:italic' : [Attachment 27325] Improved fix and improved test case, ready for final review

[bugzilla-daemon at webkit.org]

Justin Garcia <justin.garcia at apple.com> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 23496: execCommand('bold') will remove <b style='font-style:italic'>, it
should probably replace it with <span style='font-style:italic'
https://bugs.webkit.org/show_bug.cgi?id=23496

Attachment 27325: Improved fix and improved test case, ready for final review
https://bugs.webkit.org/attachment.cgi?id=27325&action=review

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
+    // Similar to isSpanWithoutAttributesOrUnstyleStyleSpan, but does not look
for apple-style-span

Would capitalize the 'a' in 'apple-style-span'.  Missing period.

+	 // FIXME: This should probably be re-written to lookup the tagname in
a
+	 // hash and match against an expected property/value pair

Missing period.

I would do all the work of replacing a node with a span inside
replaceNodeWithSpanPreservingChildrenAndAttributes instead of creating your own
EditCommand, but r=me as is.