[webkit-reviews] review requested: [Bug 23705] Messages from workers can take over main thread event loop : [Attachment 27550] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 10 21:18:01 PST 2009


Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 23705: Messages from workers can take over main thread event loop
https://bugs.webkit.org/show_bug.cgi?id=23705

Attachment 27550: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=27550&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
I've removed NSPort and NSPortMessage. After re-doing experiments looking at
bug 23865, I've realized the input events are dispatched in between timers. So
the MainThreadMac.mm practically reverted.

The change that actually helps (and which remains here) is avoiding processing
all the worker events accumulated in a FunctionQueue at once - since at some
point it could take many seconds while run loop is not running. Instead measure
the time and exit/reschedule if needed.

Also, I keep the initializeMainThreadPlatform to avoid platform ifdefs in
MainThread.cpp. 
Also, resolved against current ToT.


More information about the webkit-reviews mailing list