[webkit-reviews] review granted: [Bug 23877] Allow port to disable progress events from media elements : [Attachment 27541] Proposed patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 23877: Allow port to disable progress events from media elements
https://bugs.webkit.org/show_bug.cgi?id=23877

Attachment 27541: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=27541&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>

> Index: WebCore/html/HTMLMediaElement.h
> ===================================================================
> --- WebCore/html/HTMLMediaElement.h	(revision 40828)
> +++ WebCore/html/HTMLMediaElement.h	(working copy)
> @@ -221,6 +221,8 @@ protected:
>      OwnPtr<MediaPlayer> m_player;
>  
>      LoadRestrictions m_loadRestrictions;
> +    
> +    bool m_supportProgressEvents;

Rename to something like 'm_sendProgressEvents' and add a comment about
why you need the switch, and r=me.