[webkit-reviews] review denied: [Bug 22966] crash when destroying a webview that opened a page containing <script> tags : [Attachment 27531] fixes the crash

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 22966: crash when destroying a webview that opened a page containing
<script> tags
https://bugs.webkit.org/show_bug.cgi?id=22966

Attachment 27531: fixes the crash
https://bugs.webkit.org/attachment.cgi?id=27531&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Why would we want to clear m_singlePageGroup in this case? If the group name is
empty then this item should still be in the single page group, so you wouldn't
want to clear it. Also, m_singlePageGroup is an OwnPtr so it will be
initialized to 0, so the change to Page is unneeded and hence wrong; we left
that out on purpose.

I think the right fix is to set m_group to m_singlePageGroup.get() rather than
to 0.