[webkit-reviews] review granted: [Bug 23689] Add support for 3D to TransformationMatrix and WebKitCSSMatrix : [Attachment 27510] Replacement patch addressing one more issue

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 23689: Add support for 3D to TransformationMatrix and WebKitCSSMatrix
https://bugs.webkit.org/show_bug.cgi?id=23689

Attachment 27510: Replacement patch addressing one more issue
https://bugs.webkit.org/attachment.cgi?id=27510&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/css/WebKitCSSMatrix.cpp
> ===================================================================

> +PassRefPtr<WebKitCSSMatrix> WebKitCSSMatrix::multiply(WebKitCSSMatrix*
secondMatrix) const
>  {
>      TransformationMatrix tmp(m_matrix);
>      tmp.multiply(secondMatrix->m_matrix);

We should probably null-check secondMatrix here.

r=me with that fix.