[webkit-reviews] review denied: [Bug 23429] Frame Refactor: Move focusWindow/unfocusWindow/shouldClose/scheduleClose to Chrome : [Attachment 27497] Move stuff to Chrome..

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 9 15:33:11 PST 2009


Darin Adler <darin at apple.com> has denied Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 23429: Frame Refactor: Move
focusWindow/unfocusWindow/shouldClose/scheduleClose to Chrome
https://bugs.webkit.org/show_bug.cgi?id=23429

Attachment 27497: Move stuff to Chrome..
https://bugs.webkit.org/attachment.cgi?id=27497&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
My intent here for these functions was to have the top-frame check be in
DOMWindow, and the functions in Page not take a Frame*. I don't think it makes
sense to "close" a non-main Frame. Could you make that change?


More information about the webkit-reviews mailing list