[webkit-reviews] review requested: [Bug 23429] Frame Refactor: Move focusWindow/unfocusWindow/shouldClose/scheduleClose to Chrome : [Attachment 27496] Carry out the move

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 9 15:09:35 PST 2009


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 23429: Frame Refactor: Move
focusWindow/unfocusWindow/shouldClose/scheduleClose to Chrome
https://bugs.webkit.org/show_bug.cgi?id=23429

Attachment 27496: Carry out the move
https://bugs.webkit.org/attachment.cgi?id=27496&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Add null check for Frame::page in the FrameLoaderClient. shouldClose will be
true when we have no page or chrome()->shouldClose will return true. This
should resemble the current state with Frame::shouldClose.


More information about the webkit-reviews mailing list