[webkit-reviews] review requested: [Bug 23626] Upstream null checks in Navigator.cpp : [Attachment 27493] patch v2

[bugzilla-daemon at webkit.org]

Feng Qian <feng at chromium.org> has asked Alexey Proskuryakov <ap at webkit.org> for
review:
Bug 23626: Upstream null checks in Navigator.cpp
https://bugs.webkit.org/show_bug.cgi?id=23626

Attachment 27493: patch v2
https://bugs.webkit.org/attachment.cgi?id=27493&action=review

------- Additional Comments from Feng Qian <feng at chromium.org>
Corrected the patch by incorporating ap's comments.

1. FF returns a PluginArray/MimeTypeArray object when a frame is detached, so
WebKit does not need check here;
2. Test case is fixed by calling the same gc() function, although I don't like
it relies on 90000 object allocations;
3. Navigator::userAgent() returns an empty string if m_frame->page() is null,
avoid calling FrameLoader::userAgent which triggers assertion later in
WebFrameLoaderClient::userAgent

Interestingly FF3.1b2 on Mac crashes when loading the layout test. :(