[webkit-reviews] review granted: [Bug 23845] editing/deleting/backward-deletion.html fails on Tiger : [Attachment 27482] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 9 09:45:34 PST 2009


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 23845: editing/deleting/backward-deletion.html fails on Tiger
https://bugs.webkit.org/show_bug.cgi?id=23845

Attachment 27482: proposed fix
https://bugs.webkit.org/attachment.cgi?id=27482&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The idiom in WebCore is #ifdef BUILDING_ON_TIGER. Please change to that.

Normally we'd defined named constants for characters in CharacterNames.h rather
than using hex numbers directly.

r=me


More information about the webkit-reviews mailing list