[webkit-reviews] review denied: [Bug 23829] Make createElement non-virtual : [Attachment 27461] Proposed fix: inline HTMLDocument::createElement into Document's

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 9 04:56:36 PST 2009


Alexey Proskuryakov <ap at webkit.org> has denied 's request for review:
Bug 23829: Make createElement non-virtual
https://bugs.webkit.org/show_bug.cgi?id=23829

Attachment 27461: Proposed fix: inline HTMLDocument::createElement into
Document's
https://bugs.webkit.org/attachment.cgi?id=27461&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I've just had a second thought after noticing that isHTMLDocument() is virtual.
This patch doesn't cut back on virtual dispatches in most cases, but adds a
branch, so I don't see how it is an improvement.

Taking back the r=me, sorry.


More information about the webkit-reviews mailing list