[webkit-reviews] review granted: [Bug 23831] [CAIRO] build broken by TransformationMatrix rework : [Attachment 27468] working proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 8 11:30:37 PST 2009
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 23831: [CAIRO] build broken by TransformationMatrix rework
https://bugs.webkit.org/show_bug.cgi?id=23831
Attachment 27468: working proposed fix
https://bugs.webkit.org/attachment.cgi?id=27468&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> #if PLATFORM(CG)
> operator CGAffineTransform() const;
> +#elif PLATFORM(CAIRO)
> + operator cairo_matrix_t() const;
> #endif
Your patch is slightly out of date here; there's a new #if PLATFORM(QT)
section. Please convert to a series of #elif on commit.
r=me
More information about the webkit-reviews
mailing list