[webkit-reviews] review denied: [Bug 23818] Fix mix of unicode and ansi functions in PluginDatabaseWin.cpp : [Attachment 27448] Use unicode functions everywhere and always

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 23818: Fix mix of unicode and ansi functions in PluginDatabaseWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=23818

Attachment 27448: Use unicode functions everywhere and always
https://bugs.webkit.org/attachment.cgi?id=27448&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This patch doesn't look right to me.  The functions you are renaming are not
ANSI - e.g. SHGetValue is a macro defined to either SHGetValueA or SHGetValueW,
depending on whether UNICODE is defined. The same is true of the TEXT macro.

I'm not a huge Windows expert, but I'm sufficiently sure about these macros'
behavior to say r-. But please feel free to mark this for review again if I'm
actually wrong.