[webkit-reviews] review granted: [Bug 3248] Mouse events on OPTION element seem to be ignored : [Attachment 27444] Improved testcase

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 3248: Mouse events on OPTION element seem to be ignored
https://bugs.webkit.org/show_bug.cgi?id=3248

Attachment 27444: Improved testcase
https://bugs.webkit.org/attachment.cgi?id=27444&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I still think that size_t and calling size() on listItems directly would be
slightly better in RenderListBox::nodeAtPoint. I also would not bother with a
local variable for the result of itemBoundingBoxRect and I would have put the
declaration of "node" inside the if statement, and called it element rather
than node. But these are tiny nits. Good new test!

I also think it's unfortunate that we use offsetX/Y at all, since they have a
crazy definition. I bet we could make the code easier to understand if we used
pageX/Y instead some day. For now, fix is great, r=me!

r=me