[webkit-reviews] review granted: [Bug 23788] call style()->isOriginalDisplayInlineType() on RenderBox : [Attachment 27396] isOriginalDisplayInlineType() call

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Zalan Bujtas <zbujtas at gmail.com>'s
request for review:
Bug 23788: call style()->isOriginalDisplayInlineType() on RenderBox
https://bugs.webkit.org/show_bug.cgi?id=23788

Attachment 27396: isOriginalDisplayInlineType() call
https://bugs.webkit.org/attachment.cgi?id=27396&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 40718)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,13 @@
> +2009-02-06  Zalan Bujtas  <zbujtas at gmail.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +	   
> +	   https://bugs.webkit.org/show_bug.cgi?id=23788
> +	   call style()->isOriginalDisplayInlineType() on RenderBox instead of
RenderObject. 
> +	   
> +	   * rendering/bidi.cpp:
> +	   (WebCore::RenderBlock::skipLeadingWhitespace):
> +
>  2009-02-06  Simon Hausmann  <simon.hausmann at nokia.com>
>  
>	   Reviewed by Tor Arne Vestbø.
> Index: WebCore/rendering/bidi.cpp
> ===================================================================
> --- WebCore/rendering/bidi.cpp	(revision 40717)
> +++ WebCore/rendering/bidi.cpp	(working copy)
> @@ -1480,7 +1480,7 @@ int RenderBlock::skipLeadingWhitespace(I
>      
>	       RenderBox* box = toRenderBox(object);
>	       if (box->style()->hasStaticX()) {
> -		   if (object->style()->isOriginalDisplayInlineType())
> +		   if (box->style()->isOriginalDisplayInlineType())
>		       box->layer()->setStaticX(style()->direction() == LTR ?
leftOffset(height(), firstLine) : width() - rightOffset(height(), firstLine));
>		   else
>		       box->layer()->setStaticX(style()->direction() == LTR ?
borderLeft() + paddingLeft() : borderRight() + paddingRight());

AFAICS the end result is the same, but indeed confusing to use object here. r =
me