[webkit-reviews] review requested: [Bug 23776] Introduce 2 base classes to split WorkerMessaingProxy. : [Attachment 27441] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 6 17:40:45 PST 2009


Jian Li <jianli at chromium.org> has asked  for review:
Bug 23776: Introduce 2 base classes to split WorkerMessaingProxy.
https://bugs.webkit.org/show_bug.cgi?id=23776

Attachment 27441: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=27441&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
I fixed all the problems excepted those as commented below.

I still keep the comment for the whole class since it clarifies what the class
is intended for.

I do not add workerObjectDestroyed to WorkerConextProxy class since I think we
can merge it into terminateWorkerContext.


More information about the webkit-reviews mailing list