[webkit-reviews] review requested: [Bug 6868] make TransformationMatrix platform independent : [Attachment 27423] replacement patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 6 15:23:16 PST 2009


Chris Marrin <cmarrin at apple.com> has asked  for review:
Bug 6868: make TransformationMatrix platform independent
https://bugs.webkit.org/show_bug.cgi?id=6868

Attachment 27423: replacement patch
https://bugs.webkit.org/attachment.cgi?id=27423&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
This patch address most, if not all of Simon's comments. I've reviewed all the
changed test results and I believe that all the size differences are due to
rounding differences. The on that looks suspicious is
LayoutTests/svg/batik/textGlyphOrientationHorizontal.html, which differs by 2
pixels in some sizes. But I've looked at the pixel test results and everything
passes and looks good. So even here I think the difference must have to do with
the precision.


More information about the webkit-reviews mailing list