[webkit-reviews] review denied: [Bug 23795] Add an isRooted() method on RenderObject for use by repaint methods : [Attachment 27407] Patch, changelog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 6 13:58:46 PST 2009
Eric Seidel <eric at webkit.org> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 23795: Add an isRooted() method on RenderObject for use by repaint methods
https://bugs.webkit.org/show_bug.cgi?id=23795
Attachment 27407: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=27407&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't really like the API. I'd prefer if you added two functions instead:
RenderView* hostingView()
bool isRooted() { return hostingView(); }
Then again, from your usage, it seems isRooted is uneeded.
More information about the webkit-reviews
mailing list