[webkit-reviews] review requested: [Bug 6868] make TransformationMatrix platform independent : [Attachment 27399] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 6 08:22:46 PST 2009

Chris Marrin <cmarrin at apple.com> has asked  for review:
Bug 6868: make TransformationMatrix platform independent

Attachment 27399: Patch

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
	I have not only made TransformationMatrix platform independent
	but I've also added 3D methods, which will be used when I update
	WebKitCSSMatrix to include 3D (see
	I am now keeping a full 4x4 matrix in TransformationMatrix. I'm also
doing all
	the math as doubles rather than floats. This makes a
	go from 24 bytes to 128 bytes, but I don't think this class is used
enough to
	make this overhead will be significant.

	The change from floats to doubles has caused some differences in
rounding and
	display (sometimes things that displayed as -0.0 now display as 0.0 or
vice versa),
	so I've had to change some LayoutTest results in the SVG tests.

	NOTE: This patch is only tested on Mac. Other platforms will likely
have build issues.
	I will fix these on Windows, but I can't test on the other platforms.

More information about the webkit-reviews mailing list