[webkit-reviews] review requested: [Bug 23786] [Chromium] line-break characters in a complex text are treated as zero-width spaces : [Attachment 27383] Proposed fix for 23786

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 6 01:22:41 PST 2009


Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 23786: [Chromium] line-break characters in a complex text are treated as
zero-width spaces
https://bugs.webkit.org/show_bug.cgi?id=23786

Attachment 27383: Proposed fix for 23786
https://bugs.webkit.org/attachment.cgi?id=27383&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
The treatAsSpace() function returns true only when an input character is
U+0020, U+000A, U+000D, or U+00A0. So, this |currentAdvance| value becomes 0
only when the character is U+000A and U+000D and this code prevents the
UniscribeHelper class from treating a line-break character as whitespace. So, I
removed this code.


More information about the webkit-reviews mailing list