[webkit-reviews] review requested: [Bug 23601] DOMSelection.getRangeAt() returns a different range than the selection : [Attachment 27372] Slightly clearer diff, and added documentation of ASSERTS ojan and I kept hitting in this code.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 5 18:00:27 PST 2009


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 23601: DOMSelection.getRangeAt() returns a different range than the
selection
https://bugs.webkit.org/show_bug.cgi?id=23601

Attachment 27372: Slightly clearer diff, and added documentation of ASSERTS
ojan and I kept hitting in this code.
https://bugs.webkit.org/attachment.cgi?id=27372&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/ChangeLog		       |   36 ++++++++++++++++++++++
 WebCore/editing/Editor.cpp	       |   16 +++++-----
 WebCore/editing/Selection.cpp	       |   52 +++++++++++++++++++-------------
 WebCore/editing/Selection.h	       |   36 ++++++++++++----------
 WebCore/editing/SelectionController.h |    2 +-
 WebCore/editing/TypingCommand.cpp     |   16 +++++-----
 WebCore/page/Frame.cpp 	       |   16 ++++------
 7 files changed, 110 insertions(+), 64 deletions(-)


More information about the webkit-reviews mailing list