[webkit-reviews] review requested: [Bug 23607] REGRESSION: Clicking near an contentEditable div will focus the div, even though it shouldn't! : [Attachment 27371] Fix positionForCoordinates now with an added fix for clicking in the margins of the body.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 5 17:42:19 PST 2009
Ojan Vafai <ojan at chromium.org> has asked for review:
Bug 23607: REGRESSION: Clicking near an contentEditable div will focus the div,
even though it shouldn't!
https://bugs.webkit.org/show_bug.cgi?id=23607
Attachment 27371: Fix positionForCoordinates now with an added fix for clicking
in the margins of the body.
https://bugs.webkit.org/attachment.cgi?id=27371&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
LayoutTests/ChangeLog | 31 ++++
...ick-in-margins-inside-editable-div-expected.txt | 23 +++
.../click-in-margins-inside-editable-div.html | 13 ++
.../click-outside-editable-div-expected.txt | 20 +++
.../selection/click-outside-editable-div.html | 13 ++
.../selection/contenteditable-click-outside.html | 13 --
.../editing/selection/resources/TEMPLATE.html | 13 ++
.../click-in-margins-inside-editable-div.js | 138 ++++++++++++++++
.../resources/click-outside-editable-div.js | 55 ++++++
.../editing/selection/select-missing-image.html | 2 +-
...contenteditable-click-outside-expected.checksum | 1 -
.../contenteditable-click-outside-expected.txt | 16 --
.../selection/select-all-iframe-expected.txt | 4 +-
.../select-from-textfield-outwards-expected.txt | 2 +-
.../selection/select-missing-image-expected.txt | 3 +-
.../contenteditable-click-outside-expected.txt | 12 --
.../selection/select-all-iframe-expected.txt | 56 -------
WebCore/ChangeLog | 29 ++++
WebCore/editing/VisiblePosition.cpp | 6 +-
WebCore/rendering/RenderBlock.cpp | 174 +++++++++-----------
WebCore/rendering/RenderInline.cpp | 1 +
21 files changed, 426 insertions(+), 199 deletions(-)
More information about the webkit-reviews
mailing list