[webkit-reviews] review requested: [Bug 23774] Selection::validate() should be broken into smaller pieces to be less confusing : [Attachment 27367] Minor refactoring and cleanup to Selection code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 5 15:45:25 PST 2009


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 23774: Selection::validate() should be broken into smaller pieces to be
less confusing
https://bugs.webkit.org/show_bug.cgi?id=23774

Attachment 27367: Minor refactoring and cleanup to Selection code
https://bugs.webkit.org/attachment.cgi?id=27367&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/ChangeLog		       |   36 +++++++++++
 WebCore/editing/Editor.cpp	       |   16 +++---
 WebCore/editing/Selection.cpp	       |  104 +++++++++++++++++---------------
 WebCore/editing/Selection.h	       |   36 ++++++-----
 WebCore/editing/SelectionController.h |    2 +-
 WebCore/editing/TypingCommand.cpp     |   16 +++---
 WebCore/page/Frame.cpp 	       |   16 ++---
 7 files changed, 134 insertions(+), 92 deletions(-)


More information about the webkit-reviews mailing list