[webkit-reviews] review granted: [Bug 23767] Add custom V8 bindings for HTML5 database : [Attachment 27358] Add custom V8 bindings for HTML5 database, v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 5 14:24:07 PST 2009


Eric Seidel <eric at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 23767: Add custom V8 bindings for HTML5 database
https://bugs.webkit.org/show_bug.cgi?id=23767

Attachment 27358: Add custom V8 bindings for HTML5 database, v1
https://bugs.webkit.org/attachment.cgi?id=27358&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks sane to me.  I can't claim to be an expert in V8 or the Database spec,
but this code looks clean, and un-harmful.  I was surprised to separate objects
for each callback type.  I wonder if there is yet more code sharing which could
be done there.


More information about the webkit-reviews mailing list