[webkit-reviews] review granted: [Bug 23761] Use two-arg KURL constructor : [Attachment 27351] Uso two-arg KURL ctor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 5 13:52:59 PST 2009


Alexey Proskuryakov <ap at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 23761: Use two-arg KURL constructor
https://bugs.webkit.org/show_bug.cgi?id=23761

Attachment 27351: Uso two-arg KURL ctor
https://bugs.webkit.org/attachment.cgi?id=27351&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

> -    SubstituteData substituteData(sharedBuffer.release(), contentMimeType ?
String(contentMimeType) : "text/html", contentEncoding ?
String(contentEncoding) : "UTF-8", KURL("about:blank"), url);
> +    SubstituteData substituteData(sharedBuffer.release(), contentMimeType ?
String(contentMimeType) : "text/html", contentEncoding ?
String(contentEncoding) : "UTF-8", KURL(KURL(), "about:blank"), url);

I think that about:blank can be left as is - KURL parsing clearly won't affect
it. Not that it matters much.


More information about the webkit-reviews mailing list