[webkit-reviews] review granted: [Bug 23766] CanvasRenderingContext2D::setShadow needs else for other platforms : [Attachment 27356] v1 of patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Scott Violet <sky at google.com>'s
request for review:
Bug 23766: CanvasRenderingContext2D::setShadow needs else for other platforms
https://bugs.webkit.org/show_bug.cgi?id=23766

Attachment 27356: v1 of patch
https://bugs.webkit.org/attachment.cgi?id=27356&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Yeah, this is an OK solution for platforms w/o CYMK support, but it would be
bad if used on platforms which did. I feel like this may need a FIXME to note
that this should use a smarter color class some day.  (We should be able to
pass a CYMK color along to graphics context directly w/o having to convert it
to RGB here.)  The patch looks fine though.