[webkit-reviews] review denied: [Bug 23477] Support for WCSS extensions : [Attachment 27153] final_patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 5 10:36:05 PST 2009
Dave Hyatt <hyatt at apple.com> has denied maheshK <mahesh.kulkarni at nokia.com>'s
request for review:
Bug 23477: Support for WCSS extensions
https://bugs.webkit.org/show_bug.cgi?id=23477
Attachment 27153: final_patch
https://bugs.webkit.org/attachment.cgi?id=27153&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This patch looks fine. The only remaining thing is that WCSS code should be
wrapped in an ifdef.
Please make a new ifdef for WCSS, ENABLE(WCSS), similar to ENABLE(WML), and
wrap all of this code in it. Like WML it should be turned off by default.
More information about the webkit-reviews
mailing list