[webkit-reviews] review requested: [Bug 23741] StyleRareNonInheritedData::operator==() should not compare ContentData objects by pointer : [Attachment 27339] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 4 18:37:49 PST 2009


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 23741: StyleRareNonInheritedData::operator==() should not compare
ContentData objects by pointer
https://bugs.webkit.org/show_bug.cgi?id=23741

Attachment 27339: Patch v1
https://bugs.webkit.org/attachment.cgi?id=27339&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Proposed fix.

NOTE: There may be too much const-ness in "bool contentDataEquivalent(const
RenderStyle* otherStyle) const" now for the const_cast<>() constructs that must
be used.


More information about the webkit-reviews mailing list