[webkit-reviews] review denied: [Bug 23708] Would like to have a callback when an HTML element is first added to the DOM : [Attachment 27301] Fix whitespace issues in previous patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 4 17:51:02 PST 2009


Dave Hyatt <hyatt at apple.com> has denied Aaron Boodman <aa at chromium.org>'s
request for review:
Bug 23708: Would like to have a callback when an HTML element is first added to
the DOM
https://bugs.webkit.org/show_bug.cgi?id=23708

Attachment 27301: Fix whitespace issues in previous patch
https://bugs.webkit.org/attachment.cgi?id=27301&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Nearly there...

Looks like your Changelog needs to be regenerated?

The change to HTMLParser.cpp could just be a single if statement.

if (localName == htmlTag && document->frame())

I don't know if Qt wants this or not but for completeness you would need to
patch their XMLTokenizer as well.


More information about the webkit-reviews mailing list