[webkit-reviews] review requested: [Bug 23496] execCommand('bold') will remove <b style='font-style:italic'>, it should probably replace it with <span style='font-style:italic' : [Attachment 27325] Improved fix and improved test case, ready for final review

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 23496: execCommand('bold') will remove <b style='font-style:italic'>, it
should probably replace it with <span style='font-style:italic'
https://bugs.webkit.org/show_bug.cgi?id=23496

Attachment 27325: Improved fix and improved test case, ready for final review
https://bugs.webkit.org/attachment.cgi?id=27325&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 LayoutTests/ChangeLog				    |	14 ++
 .../convert-style-elements-to-spans-expected.txt   |	20 +++
 .../convert-style-elements-to-spans.html	    |	13 ++
 .../resources/convert-style-elements-to-spans.js   |  125 ++++++++++++++++++++
 WebCore/ChangeLog				    |	40 ++++++
 WebCore/WebCore.xcodeproj/project.pbxproj	    |	 8 ++
 WebCore/css/CSSStyleDeclaration.h		    |	 1 +
 WebCore/dom/NamedAttrMap.h			    |	 2 +
 WebCore/editing/ApplyStyleCommand.cpp		    |	73 ++++++++----
 WebCore/editing/ApplyStyleCommand.h		    |	 4 +-
 WebCore/editing/CompositeEditCommand.cpp	    |	12 ++
 WebCore/editing/CompositeEditCommand.h 	    |	 2 +
 .../RemoveNodePreservingChildrenCommand.cpp	    |	 3 +-
 WebCore/editing/ReplaceNodeWithSpanCommand.cpp     |	87 ++++++++++++++
 WebCore/editing/ReplaceNodeWithSpanCommand.h	    |	62 ++++++++++
 15 files changed, 437 insertions(+), 29 deletions(-)