[webkit-reviews] review requested: [Bug 23625] Skia platform doesn't render text to a canvas or support clipping to an image buffer : [Attachment 27319] Fixes three bugs introduced in first patch

[bugzilla-daemon at webkit.org]

Scott Violet <sky at google.com> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 23625: Skia platform doesn't render text to a canvas or support clipping to
an image buffer
https://bugs.webkit.org/show_bug.cgi?id=23625

Attachment 27319: Fixes three bugs introduced in first patch
https://bugs.webkit.org/attachment.cgi?id=27319&action=review

------- Additional Comments from Scott Violet <sky at google.com>
This fixes three bugs found in the first patch:

. When a new layer was started clipped to an image we used the
  assignment operator to copy the SkBitmap. If the SkBitmap owns it's
  pixels, this is not the right thing to do. Instead we need to create
  a copy of the image.
. State holds an SkBitmap by value. State's copy constructor does a
  memcpy. This is confusing and subtle, I've converted to use a member
  initializer list which I think is clearer and less error prone.
. When creating a new layer there is no need to copy the clip image.