[webkit-reviews] review granted: [Bug 23731] Add JSCCustom and V8Custom as extended IDL attributes : [Attachment 27316] v1 patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Darin Fisher (:fishd, Google)
<darin at chromium.org>'s request for review:
Bug 23731: Add JSCCustom and V8Custom as extended IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=23731

Attachment 27316: v1 patch
https://bugs.webkit.org/attachment.cgi?id=27316&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>	       $numCustomAttributes++ if
$attribute->signature->extendedAttributes->{"Custom"};
>	       $numCustomAttributes++ if
$attribute->signature->extendedAttributes->{"CustomGetter"};
>	       $numCustomAttributes++ if
$attribute->signature->extendedAttributes->{"CustomSetter"};
> +	       $numCustomAttributes++ if
$attribute->signature->extendedAttributes->{"JSCCustom"};

This will do the wrong thing if someone includes both "Custom" and "JSCustom"
for the same attribute; and it won't report an error. It would be better to use
|| instead or consider it an error.

>	   $numCustomFunctions++ if
$function->signature->extendedAttributes->{"Custom"};
> +	   $numCustomFunctions++ if
$function->signature->extendedAttributes->{"JSCCustom"};

Same comment.

r=me