[webkit-reviews] review requested: [Bug 23731] Add JSCCustom and V8Custom as extended IDL attributes : [Attachment 27316] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 4 09:40:51 PST 2009


Darin Fisher (:fishd, Google) <darin at chromium.org> has asked  for review:
Bug 23731: Add JSCCustom and V8Custom as extended IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=23731

Attachment 27316: v1 patch
https://bugs.webkit.org/attachment.cgi?id=27316&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
In this patch, I define JSCCustom and make use of it in a few IDL files.  I
also modify Document.idl to make use of V8Custom, which is known only to the
CodeGeneratorV8.pm module (that has yet to be upstreamed).

I did not add JSCCustomGetter or JSCCustomSetter since they are not needed.  I
could add those for completeness, but it seemed better to just focus on what is
actually needed.


More information about the webkit-reviews mailing list