[webkit-reviews] review denied: [Bug 8475] document.lastModified gives no output if the response doesn't have a Last-Modified header : [Attachment 27287] Incorporates the style and other feedback from the review.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Jon at Chromium
<jon at chromium.org>'s request for review:
Bug 8475: document.lastModified gives no output if the response doesn't have a
Last-Modified header
https://bugs.webkit.org/show_bug.cgi?id=8475

Attachment 27287: Incorporates the style and other feedback from the review.
https://bugs.webkit.org/attachment.cgi?id=27287&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r-, because we want to match other browsers, not the draft spec.

You have tabs in ChangeLog, please use spaces.

+    DEFINE_STATIC_LOCAL(AtomicString,unixEpoch,("01/01/1970 00:00:00"));

Not that this matters any more if we are not going to use the UNIX epoch, but
our coding style asks for spaces after commas.

+    // See http://www.w3.org/TR/html5/dom.html#lastmodified
+    // See http://crbug.com/2400

I'm not sure if these comments add much - once we settle on a certain behavior,
and the spec is fixed, it will hopefully be pretty clear why we chose it, even
without bug references. And there's always svn blame.